freshgum-bubbles / typedi

Elegant Dependency Injection in TypeScript and JavaScript.
http://typedi.js.org/
MIT License
53 stars 3 forks source link

Disable stripInternal in TS config #147

Closed freshgum-bubbles closed 11 months ago

freshgum-bubbles commented 11 months ago

stripInternal is disabled due to it causing issues in bundles, wherein types marked as @internal were being elided from the build, even when other parts of the package depended upon them.

See: https://github.com/freshgum-bubbles/typedi/issues/146


The long-term solution to this is migrating to api-extractor, which has been on the backburner for a while now.

changeset-bot[bot] commented 11 months ago

🦋 Changeset detected

Latest commit: 56fed55db57c6ab5712f1da5b9d92285449a314c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ---------------- | ----- | | @freshgum/typedi | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

freshgum-bubbles commented 11 months ago

Related note: need to set up package testing infra :/

github-actions[bot] commented 10 months ago

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.