fix(types): correct type definitions

freshollie / jest-dynalite

Jest preset to run Dynalite (DynamoDB local) per test runner

https://www.npmjs.com/package/jest-dynalite

MIT License

151 stars 16 forks source link

fix(types): correct type definitions #59

Closed samchungy closed 3 years ago

samchungy commented 3 years ago

Changes:

Fix type definitions
Bump up @aws-sdk/client-dynamodb dev dependency version due to type errors https://github.com/aws/aws-sdk-js-v3/issues/1919
Enable libcheck

samchungy commented 3 years ago

I guess it's one of those things which is enabled by default and skipLibCheck is the thing that overrides it? My workplace's rule of thumb is to keep it enabled, unless you really really need to disable it. I guess it helps weed out potential issues in other dependencies?

samchungy commented 3 years ago

I appreciate this library though, I got recommended to use this by a colleague and smashed out some tests today, so thanks a bunch man 🎉

freshollie commented 3 years ago

I guess it helps weed out potential issues in other dependencies?

Yeah, I just dunno if that's useful. Typescript still checks how you use the signatures with it disabled.

I got recommended to use this by a colleague and smashed out some tests today, so thanks a bunch man

No worries! Glad it's of use to people!

freshollie commented 3 years ago

Interesting. CI didn't run on these commits 🤔