freshollie / monkeyboard-radio-android

Monkeyboard - FM & DAB/DAB+ radio for android
GNU General Public License v3.0
38 stars 18 forks source link

Make the Volume, mode, and save channel; widgets more usable #26

Open marcusbirkin opened 4 years ago

marcusbirkin commented 4 years ago

Rescaled and moved Volume, mode, and save channel; widgets Particularly in landscape devices, these buttons could be difficult to use on embedded devices

marcusbirkin commented 4 years ago

Landscape: image Portrait: image

freshollie commented 4 years ago

Looks good, but does this work with SlideShow images on the screen? The image was already pretty constrained? What does it look like on 7" devices?

marcusbirkin commented 4 years ago

I've never seen slideshow pictures, but the widget for that remained unchanged.

Screen shot from real hardware, running on Android 8.1 with a 7" screen (n.b. low signal due to no antenna): monkeyboard

freshollie commented 4 years ago

Why does the scaled icon look so much worse on real hardware? Very weird. Yeah no SlideShow in the UK. Maybe this could be something which could be activated in settings?

marcusbirkin commented 4 years ago

I've increased the size of the icon, and then scaled down when drawn. That removes the scaling artifacts.

As to why this isn't shown in the simulator, maybe the emulated gfx chip is better than the cheap one in my hardware?