freswa / dovecot-xaps-plugin

MIT License
36 stars 7 forks source link

404 errors for users that do not use apple push notifications #5

Closed mstilkerich closed 3 years ago

mstilkerich commented 3 years ago

Hello,

I recently upgraded to the current master using the new HTTP protocol to communicate with the plugin.

Now I am getting tons of log entries like

Dovecot:

imap(xxx)<123><123>: Error: Error when sending notification: 404 Not Found: 4 Time(s)

xapsd:

Jun 15 19:35:39 keira xapsd[9692]: time="2021-06-15T19:35:39+02:00" level=warning msg="No registration found for username: xxx"

To my understanding, the dovecot plugin notifies the daemon on any new message because it is not aware of which users registered for push notifications. Hence, it is not an error if a user did not register for push notifications is not known to xapsd, and it should be avoided to fill the logs with error messages in this case. Particularly, this is the case for all users of the imap servers that don't use Apple products.

Oh, and btw thanks for your awesome work of this daemon, particularly the automatic renewal of the certificates. I'm quite happy to be rid of my yearly appointment to renew the certificate with my old Lion VM, which in the past required me to even use a mitmproxy because Lion does not support the current TLS versions required by Apple's servers anymore 👍