search

freudi74 / gradle-cmake-plugin

A gradle plugin that makes CMake calls from gradle build scripts easy.
Apache License 2.0
20 stars 9 forks source link

buildConfig doesn't work #6

Open mikehearn opened 3 years ago

mikehearn commented 3 years ago

I think the logic is bad on this line:

https://github.com/freudi74/gradle-cmake-plugin/blob/master/src/main/java/net/freudasoft/CMakeBuildTask.java#L80

It's saying to add the flag if the property is NOT present, which is wrong. It should be added if the property IS present, surely?

shearer12345 commented 2 years ago

For reference, this appears to be a duplicate of #1, with it's PR #2

KitsuneAlex commented 2 years ago

You can get an unofficial build for as i explain in #4 if this is still relevant to you two :)

KitsuneAlex commented 2 years ago

My updated fork is now available via Maven too, check it out :)