Add new function that takes a callback which gets run whenever dark/light mode changes

[frewsxcv]

• [ ] Mac
• [ ] Windows
• [ ] Linux

[edfloreshz]

I'm on it!

[frewsxcv]

Some relevant macOS links:

• https://github.com/cormacrelf/dark-notify
• https://github.com/planet-s/winit/blob/28023d9f5bb74b66a9b294b4c8fef6c46a9d9b92/src/platform_impl/macos/view.rs#L287-L295
• https://stackoverflow.com/a/56091382/15385214
• https://stackoverflow.com/a/26472651/15385214
  • Maybe relevant Rust code

[edfloreshz]

I have a working function that takes a callback.

I'm calling dark-light::detect on a loop and invoking the callback function when the theme changes.

I want to leave this behavior for distros that haven't yet implemented color-scheme since there's no single way we can get every DE to notify us of a change in theme. Let me know if there's a better way to do this.

For the ones that have, I would like to get a notification from dbus when that key changes value, can dbus do that?

[Be-ing]

Yes you can get a notification from dbus. That would be better than a perpetual loop.

[edfloreshz]

Any ideas for distros that haven't implemented color-scheme? I really don't like that loop 😅

[Be-ing]

For the ones that rely on config files, you could use https://lib.rs/crates/notify

[edfloreshz]

I considered using that crate, I'll see what I can do. 😉

[edfloreshz]

Yes you can get a notification from dbus. That would be better than a perpetual loop.

I have little experience working with dbus, could you point me in the right direction?

[Be-ing]

I don't have much experience with dbus either, but I do know it can emit signals that your application can receive. This looks like the signal we want.

[edfloreshz]

Big help! Thanks 🙏🏼

[d2weber]

See this repo where I implemented listening color scheme preferences from freedesktops dbus: https://github.com/d2weber/tintanum