search

frextrite / coala-jetbrains

coala plugin for JetBrains IDEs - coala provides a unified interface for linting and fixing code with a single configuration file, regardless of the programming languages used.
https://coala.io
GNU Affero General Public License v3.0
2 stars 1 forks source link

Feature highlights and annotations in IDE #23

Closed frextrite closed 5 years ago

frextrite commented 5 years ago

highlighting and annotating inside the IDE is implemented

frextrite commented 5 years ago

Travis builds failing for OpenJDK 11. Reported https://travis-ci.community/t/maven-received-status-code-403-from-server-forbidden/4641

ksdme commented 5 years ago

30 Commits are unacceptable in a single PR.

ksdme commented 5 years ago

Please clean it up and also ensure we have high test coverage (>75%).

frextrite commented 5 years ago

I agree 30 commits are a lot. I could squash a few beginning commits into a single commit, but all of the commits are relevant imo. At this stage, I had all of the components created and it's all about integrating them with each-other. I could've gone with one class/PR but that would've just taken longer to code (and make sure everything works) and to get it out.

As far as the code goes, I've re-iterated multiple times to refactor+optimize it and I believe there would be no (a few maybe?) complaints regarding the code.

frextrite commented 5 years ago

Split into multiple-inter-connected PRs. #24 #25 #26 #27 #28

The downside: Maintaining can be a pain. Changing in one PR would result in rebasing all the remaining PRs.