search

freyacodes / Lavalink-Client

The classic Lavalink client for bots written for JVM using JDA or other frameworks
MIT License
41 stars 51 forks source link

Update Lavaplayer dependencies/change Audiosource implementation #44

Closed Flexusma closed 3 years ago

Flexusma commented 3 years ago

The currently used lavaplayer version is not compatible with youtube anymore (throws 410) but the updated version (1.3.73) changed the soundcloud-source builder -> throws an error

New Source implementation for soundcloud in lavaplayer: playerManager.registerSourceManager(SoundCloudAudioSourceManager.createDefault());

Current implementation in Lavalink-Client: (LavalinkUtil.java) PLAYER_MANAGER.registerSourceManager(new SoundCloudAudioSourceManager());

When you manually update lavaplayer this exception is thrown: java.lang.NoSuchMethodError: com.sedmelluq.discord.lavaplayer.source.soundcloud.SoundCloudAudioSourceManager: method 'void <init>()' not found at lavalink.client.LavalinkUtil.<clinit>(LavalinkUtil.java:52)

Flexusma commented 3 years ago

Ah, i just looked at the source and saw you already updated this, maybe create a new maven/gradle release. Seems like that hasn't been updated

Flexusma commented 3 years ago

This might be avoidable by making this the default maven/gradle dependency listed in the readme: `

com.github.freyacodes 
        <artifactId>Lavalink-Client</artifactId>
        <version>master</version>
    </dependency>`

That way you always get the current master build, and you are not dependent on creating new releases. Anyway, I will close this again as it is resolved