search

freyacodes / archived-bot

A Discord music bot serving music in over 3 million discord servers
https://fredboat.com/docs
MIT License
488 stars 207 forks source link

Bot breaks after a day or two. #170

Closed yellowcooln closed 7 years ago

yellowcooln commented 7 years ago

It will not join a voice channel even though we are in a voice channel. discord_2017-04-30_22-08-34 Once I restart the service using the systemctl stop fredboat.service then systemctl start fredboat.service. It works fine till it breaks and I have to do it over again. Yes it has permissions to join the channel. After I restart It can join the channel. It now also hides who posted the ;;play link in the chat now when it didn't before. 2017-04-30_22-35-57

freyacodes commented 7 years ago

Anything suspicious in the logs?

yellowcooln commented 7 years ago

There is a ton of this in the log. putty_2017-04-30_22-19-55 1 I can pastebin the latest log if you like.

freyacodes commented 7 years ago

Can you show me the output of ;;stats?

yellowcooln commented 7 years ago

Nothing happens when I do it in discord. I get a error in the logs. [00:40:54] [ INFO ] [EventListenerBoat] Knock Knock N1bba Yellowcooln ;;stats [00:40:54] [ INFO ] [EventListenerBoat] Unknown command:

freyacodes commented 7 years ago

Sorry, I meant ;;mstats

yellowcooln commented 7 years ago

discord_2017-05-01_00-43-17

freyacodes commented 7 years ago

I think I might know what's causing this, but I don't have time to investigate further right now. I'll probably write a debug script that you can run to see what's going on.

yellowcooln commented 7 years ago

Okay thank you. putty_2017-05-01_00-49-55 That is the spec's of the VPS that is running the bot if that is needed.

schnapster commented 7 years ago

Possibly not related to this, but you are running an outdated FredBoat version. Please update.

yellowcooln commented 7 years ago

I am now running the newest version found on github. discord_2017-05-01_15-59-59 It still removes the ;;play link like it did in the gif above.

schnapster commented 7 years ago

It's not a bug, it's a feature.

Deny the bot the Manage Messages permission and it will not be able to do that.

yellowcooln commented 7 years ago

Okay. Thanks!

On May 1, 2017 4:05 PM, "Napster" notifications@github.com wrote:

It's not a bug, it's a feature.

Deny the bot the Manage Messages permission and it will not be able to do that.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Frederikam/FredBoat/issues/170#issuecomment-298418491, or mute the thread https://github.com/notifications/unsubscribe-auth/AL76o5QbpxZDwEPW-5SNMaksEK8gl2v5ks5r1jsdgaJpZM4NMx4n .

freyacodes commented 7 years ago

It would be super helpful if you could take a heap dump once you run into these problems again:

jmap -dump:format=b,file=heap.hprof <pid>

Remember that the resulting file will contain all the secrets from credentials.yaml. You can send it to me in private to frogkr@gmail.com. This is useful because I think we are retaining multiple instances of JDA, of which we should only have one in such a small bot.

yellowcooln commented 7 years ago

Next time it happens I'll send it to you.

PS. It's my favorite music bot. That's why I wanted to host my own.

On May 1, 2017 4:08 PM, "Frederik Ar. Mikkelsen" notifications@github.com wrote:

It would be super helpful if you could take a heap dump once you run into these problems again:

jmap -dump:format=b,file=heap.hprof

Remember that the resulting file will contain all the secrets from credentials.yaml. You can send it to me in private to frogkr@gmail.com. This is useful because I think we are retaining multiple instances of JDA, of which we should only have one in such a small bot.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Frederikam/FredBoat/issues/170#issuecomment-298419204, or mute the thread https://github.com/notifications/unsubscribe-auth/AL76o49aCvq943Ki499b5uMDkK1jiB97ks5r1jvPgaJpZM4NMx4n .

schnapster commented 7 years ago

@Frederikam keep in mind yellowcooln is running on the master branch, which is missing a few memory related commits, so the heapdump might well not be as pure as expected.

yellowcooln commented 7 years ago

I noticed that I can have a combination of both bots. The only thing I don't like is that ;;volume is disabled when I do this.

Example; When I have the bot set to development: true and patron: false I can do the fun and meme commands and have the full function of the bot. The only thing that it won't do is ;;volume.

But if I set development and patron to true the ::volume works but I lose all the other commands. Is it possible to have both? If not, could it be implemented?

Also, anyway that I can add more RAM to the bot? I've seen the bot only having about 1MB remaining before and would like to add more. I've tried -XMx512M in run.sh and that didn't work,

No update on the problem I was having. Probably because I've restarted the bot about 10 times in the last 12 hours.

schnapster commented 7 years ago

There is no reason volume shouldn't work in DEVELOPMENT, as long as it stays disabled for MUSIC. I'll fix that later unless someone beats me to it. RAM usage statistics are a bit tricky. Java likes to fill up what it can get, and the architecture of JDA and the music player both constantly receiving/sending data means the RAM will always fill up rather fast, but it will also be easily and regularly released by the garbage collector. Unless you are seeing the garbage collector locking down the whole thing while trying to recover memory, you don't really need to give it more.

yellowcooln commented 7 years ago

Here is an example on what I mean. https://puu.sh/vDnBU/e0ac9d8dc6.png I would like to know if it's possible to add more RAM. Because I feel like I have wasted ram on my vps.

yellowcooln commented 7 years ago

Since the last time I posted I haven't restarted the bot. It was working fine. Then I noticed it wasn't online today. I check the logs it says it lost connection. As I'm reading the logs it comes back online. Yay!

So I issue the ;;join command. Nothing. ;;mstats Nothing. Weird.

I ran the dump because you told me to. I also have the log file in the zip too.

freyacodes commented 7 years ago

Looks like the bot was gracefully closed, so likely an issue with your system or something, except something must have hanged.

Bear in mind that by posting the hprof file, you're making all your bot's credentials.yml contents available to anyone who knows how to read it.

yellowcooln commented 7 years ago

Ahhh shit I forgot. You have it I'm deleting it.

On Wed, May 10, 2017 at 12:17 AM, Frederik Ar. Mikkelsen < notifications@github.com> wrote:

Looks like the bot was gracefully closed, so likely an issue with your system or something, except something must have hanged.

Bear in mind that by posting the hprof file, you're making all your bot's credentials.yml contents available to anyone who knows how to read it.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Frederikam/FredBoat/issues/170#issuecomment-300369206, or mute the thread https://github.com/notifications/unsubscribe-auth/AL76o-N54uVKPGjwJ66CTyWHMPcPlIscks5r4TpfgaJpZM4NMx4n .

-- Nicholas Seale

Nanabell commented 7 years ago

i would still suggest that you renew your bot token atleast if you havent done that already

schnapster commented 7 years ago

Please let us know if these issues are still happening in the current release. Closing for now.