search

freyacodes / archived-bot

A Discord music bot serving music in over 3 million discord servers
https://fredboat.com/docs
MIT License
488 stars 207 forks source link

YT Alternative link doesn't parse correctly #390

Open knight-ryu12 opened 7 years ago

knight-ryu12 commented 7 years ago

Like, https://www.youtube.com/watch_videos?video_ids=06H_6oI4EK4&source=uberaffe This one doesn't parse as YT.

schnapster commented 7 years ago

This is fixed in the lavaplayer fork we are running (in dev, hasn't hit production yet), thanks to @Shredder121's PR which is part of the fork. Hope it gets merged into upstream soon. Related links: https://github.com/FredBoat/lavaplayer/tree/fork https://github.com/sedmelluq/lavaplayer/pull/70

knight-ryu12 commented 7 years ago

Thanks.

2017/11/08 午前5:42 "Napster" notifications@github.com:

Closed #390 https://github.com/Frederikam/FredBoat/issues/390.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Frederikam/FredBoat/issues/390#event-1330559670, or mute the thread https://github.com/notifications/unsubscribe-auth/ALa_E86TaFpdwDcfZN6OcQ1y3JDP6InCks5s0MDCgaJpZM4QQt5W .

Shredder121 commented 7 years ago

I don't think this one would work though. Unless the http source manager is used to resolve the redirect?

schnapster commented 7 years ago

Right, disabling the http source manager breaks this.

freyacodes commented 6 years ago

This issue can be fixed by doing a PR against the youtube source manager that matches these URLs