search

freyacodes / archived-bot

A Discord music bot serving music in over 3 million discord servers
https://fredboat.com/docs
MIT License
487 stars 210 forks source link

Fix Spotify playlist handling #585

Closed OtterBoops closed 5 years ago

OtterBoops commented 5 years ago

Added bonus of "borrowing" Nana's migration of SpotifyPlaylistSourceManager to Kotlin.

schnapster commented 5 years ago

For better reviewability, it helps separating tasks like reformatting a file or converting it to kotlin from changes to the logic into individual commits.

freyacodes commented 5 years ago

@napstr yeah exactly.

I trust that Otter knows what he is doing with this one. We'll publicly shame him if this breaks in production :eyes:

OtterBoops commented 5 years ago

For better reviewability, it helps separating tasks like reformatting a file or converting it to kotlin from changes to the logic into individual commits.

Great point. I'll keep it into consideration ..

@napstr yeah exactly.

I trust that Otter knows what he is doing with this one. We'll publicly shame him if this breaks in production 👀

.. next time I break patron.

Jokes aside, I agree and will do it from now on.