Closed Nanabell closed 3 years ago
It would be easy for me to add a docker build to my CI server. Though would it not be easier to provide a docker-compose file instead of several command options?
At any rate, I don't think we should be recommending options that don't use volumes for configuration and persistence.
i can include a docker-compose.yml file as well sure, keept it on cli since you have to create the db folder and own it before running anyways.
Should i completely remove the other options / all cli options and only include the compose version? And do you want config settings via file as well or is fine as env vars? since you could set it like this
version: "3"
services:
ukulele:
image: ukulele
environment:
CONFIG_TOKEN: MY_SECRET_TOKEN
CONFIG_PREFIX: "!"
I think it would be simplest to just use the config file and only recommend docker-compose.
Pretty simple Dockerfile to build a ukulele Docker Image.
Wrote the documentation in mind with ukulele being uploaded to dockerhub but thats obviously not a todo i can do. Alternatively i can add the build command & a Dockerfile that will build the project inside a container so endusers wont need java 11 installed.