freyacodes / ukulele

Simple self-contained Discord music bot
MIT License
157 stars 75 forks source link

Invalid status code: 400 #73

Open jocull opened 5 months ago

jocull commented 5 months ago

See

This can be addressed by changing the implementation for lavaplayer to:

    // Use a commit version right after 2.1.0
    // See https://github.com/lavalink-devs/lavaplayer/pull/70
    implementation("com.github.lavalink-devs.lavaplayer:lavaplayer:727959e9f6")

Will work on a PR when I can.

jocull commented 5 months ago

I updated https://github.com/freyacodes/ukulele/pull/69 to include this fix as well

jocull commented 5 months ago

The PR has been updated, a Docker image is released. Initial feedback reports that this addresses the problem. I've moved to the proper release of lavaplayer as well instead of a commit hash 🙂

kiloforce commented 4 months ago

@jocull your ghcr.io/jocull/ukulele:jda-5 change appeared to be working last week, but this week getting a new error. Likely YouTube changed something again?

2024-04-02 00:49:57.464  INFO 1 --- [atcher-worker-1] dev.arbjerg.ukulele.jda.CommandManager   : Invocation: ;play dnd ambient music
2024-04-02 00:49:58.142 ERROR 1 --- [back-1-thread-1] dev.arbjerg.ukulele.audio.Player         : Track exception

com.sedmelluq.discord.lavaplayer.tools.FriendlyException: Video returned by YouTube isn't what was requested
        at com.sedmelluq.discord.lavaplayer.source.youtube.DefaultYoutubeTrackDetailsLoader.load(DefaultYoutubeTrackDetailsLoader.java:59) ~[lavaplayer-2.1.1.jar!/:na]
        at com.sedmelluq.discord.lavaplayer.source.youtube.DefaultYoutubeTrackDetailsLoader.loadDetails(DefaultYoutubeTrackDetailsLoader.java:36) ~[lavaplayer-2.1.1.jar!/:na]
        at com.sedmelluq.discord.lavaplayer.source.youtube.YoutubeAudioTrack.loadBestFormatWithUrl(YoutubeAudioTrack.java:83) ~[lavaplayer-2.1.1.jar!/:na]
        at com.sedmelluq.discord.lavaplayer.source.youtube.YoutubeAudioTrack.process(YoutubeAudioTrack.java:44) ~[lavaplayer-2.1.1.jar!/:na]
        at com.sedmelluq.discord.lavaplayer.track.playback.LocalAudioTrackExecutor.execute(LocalAudioTrackExecutor.java:101) ~[lavaplayer-2.1.1.jar!/:na]
        at com.sedmelluq.discord.lavaplayer.player.DefaultAudioPlayerManager.lambda$executeTrack$2(DefaultAudioPlayerManager.java:330) ~[lavaplayer-2.1.1.jar!/:na]
        at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) ~[na:na]
        at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) ~[na:na]
...
jocull commented 4 months ago

@kiloforce It seems like this is required upstream: https://github.com/lavalink-devs/lavaplayer/pull/93

In the meantime we can use the snapshot version from this repo. The branch and PR are updated. Docker images are also updated.

kiloforce commented 4 months ago

Thanks!