search

freystef / Rails

18xx games moderator
GNU General Public License v2.0
9 stars 9 forks source link

Building Bug #13

Open madoar opened 7 years ago

madoar commented 7 years ago

Another bug we discovered was a building bug in 1835 with Rails 2.0 RC1. Given the situation in the appended screenshot, the bayern owner can't build field K9, even through he should have access to it. The same problem appears for the owner of the hessen. bauen-bug

Hawke commented 7 years ago

This seems correct -- assuming Hessen is the HE station and Bayern is the BY station, tile K9 is not accessible by either (it would require backtracking on tile K7)

madoar commented 7 years ago

Are you sure? I see a route from: J8 -> J6 -> J4 -> I5 -> H4 -> I3 -> J4 -> K5 -> J6 -> K7 -> L8 -> L10 -> K9.

Hawke commented 7 years ago

Ah, right you are indeed.

neutronc commented 7 years ago

That is a bug in the routefinding algorithmn. As usual please upload a save game for easier debug and fix. Thanks

madoar commented 7 years ago

Sorry, I don't have a save game for this bug. I only have the provided screenshot. I've just tried to recreate the problem with the use of the map correction tool, but it doesn't seem to be this easily reproducible. During my tests it was possible for the BY to place K9, but I didn't open the HE yet. I guess it's possible that the problem may be correlated to the opening of HE and it's appearance at Frankfurt and/or the building order. In addition there were not that many routes built in my test case than in the provided screenshot, which may be a reason too.

neutronc commented 7 years ago

Please recheck if that comes up again after release of RC3.

Thanks

madoar commented 7 years ago

Thanks for the heads up! I'll test the new RC3 after it has been released.

On another note: I've read in the rails mailing list on sourceforge, that you're planning/thinking about moving the main repository to github. I personally think this is a good idea. If you do so, I believe it would be best to create a new open source github organization for the project. This would allow you to have multiple maintainers with admin rights for the project, which makes the project more robust against inactive maintainers.

In addition I would suggest to add automatic testing and building with travis ci. This would prevent mishaps like with the release of RC2.