freystef / Rails

18xx games moderator
GNU General Public License v2.0
9 stars 9 forks source link

Rails doesn't show revenue routes and doesn't automatically calculate the revenues #17

Closed madoar closed 7 years ago

madoar commented 7 years ago

While trying the new version of Rails 2.0 RC2, a few friends of mine together with me discovered that the new rails version doesn't automatically calculate the revenue routes. Instead it shows a revenue of 0 by default, even if there exists a route that could be driven by a train and create a positive revenue. While the revenue isn't calculated automatically it's still possible to set it manually.

neutronc commented 7 years ago

Am 29.01.2017 um 21:02 schrieb madoar:

While trying the new version of Rails 2.0 RC2, a few friends of mine together with me discovered that the new rails version doesn't automatically calculate the revenue routes. Instead it shows a revenue of 0 by default, even if there exists a route that could be driven by a train and create a positive revenue. While the revenue isn't calculated automatically it's still possible to set it manually.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/freystef/Rails/issues/17, or mute the thread https://github.com/notifications/unsubscribe-auth/AGcIyVu_hVW0BE4JMLEDkhJ-y3NRO6qVks5rXPBVgaJpZM4Lw49Y.

Please check that in the Gameoptions the Revenuecalculation has been enabled.

Regards,

Martin

madoar commented 7 years ago

We checked, our configuration was: selected-options

neutronc commented 7 years ago

Can you attach a save game ?

Thanks in advance

Gesendet mit der Telekom Mail App http://www.t-online.de/service/redir/emailmobilapp_ios_smartphone_footerlink.htm

-----Original-Nachricht----- Von: madoar <notifications@github.com mailto:notifications@github.com > Betreff: Re: [freystef/Rails] Rails doesn't show revenue routes and doesn't automatically calculate the revenues (#17) Datum: 29.01.2017, 23:21 Uhr An: freystef/Rails <Rails@noreply.github.com mailto:Rails@noreply.github.com > CC: Dr. Martin Brumm <dr.martin.brumm@t-online.de mailto:dr.martin.brumm@t-online.de >, Comment < comment@noreply.github.com mailto:comment@noreply.github.com >

We checked, our configuration was: [selected-options] https://cloud.githubusercontent.com/assets/18488086/22408463/8bcf0250-e679-11e6-925c-2ce699edc960.png

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/freystef/Rails/issues/17#issuecomment-275951094 , or mute the thread https://github.com/notifications/unsubscribe-auth/AGcIyZ7NZYETSza8dbR125N8nM4icKm9ks5rXRDXgaJpZM4Lw49Y .

madoar commented 7 years ago

I've just tried to reproduce the previous stated situation. My attempt failed when I wanted to save the game state. After entering a destination file name and pressing on "save" I got the following stacktrace:

Exception in thread "AWT-EventQueue-0" java.lang.ArrayIndexOutOfBoundsException: 1 at net.sf.rails.ui.swing.GameUIManager.saveGame(GameUIManager.java:949) at net.sf.rails.ui.swing.StatusWindow.actionPerformed(StatusWindow.java:670) at javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:2022) at javax.swing.AbstractButton$Handler.actionPerformed(AbstractButton.java:2348) at javax.swing.DefaultButtonModel.fireActionPerformed(DefaultButtonModel.java:402) at javax.swing.DefaultButtonModel.setPressed(DefaultButtonModel.java:259) at javax.swing.AbstractButton.doClick(AbstractButton.java:376) at javax.swing.plaf.basic.BasicMenuItemUI.doClick(BasicMenuItemUI.java:833) at javax.swing.plaf.basic.BasicMenuItemUI$Handler.mouseReleased(BasicMenuItemUI.java:877) at java.awt.Component.processMouseEvent(Component.java:6533) at javax.swing.JComponent.processMouseEvent(JComponent.java:3324) at java.awt.Component.processEvent(Component.java:6298) at java.awt.Container.processEvent(Container.java:2236) at java.awt.Component.dispatchEventImpl(Component.java:4889) at java.awt.Container.dispatchEventImpl(Container.java:2294) at java.awt.Component.dispatchEvent(Component.java:4711) at java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4888) at java.awt.LightweightDispatcher.processMouseEvent(Container.java:4525) at java.awt.LightweightDispatcher.dispatchEvent(Container.java:4466) at java.awt.Container.dispatchEventImpl(Container.java:2280) at java.awt.Window.dispatchEventImpl(Window.java:2746) at java.awt.Component.dispatchEvent(Component.java:4711) at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:758) at java.awt.EventQueue.access$500(EventQueue.java:97) at java.awt.EventQueue$3.run(EventQueue.java:709) at java.awt.EventQueue$3.run(EventQueue.java:703) at java.security.AccessController.doPrivileged(Native Method) at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:80) at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:90) at java.awt.EventQueue$4.run(EventQueue.java:731) at java.awt.EventQueue$4.run(EventQueue.java:729) at java.security.AccessController.doPrivileged(Native Method) at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:80) at java.awt.EventQueue.dispatchEvent(EventQueue.java:728) at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:201) at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:116) at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:105) at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101) at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:93) at java.awt.EventDispatchThread.run(EventDispatchThread.java:82)

This is the configuration that produces the previous stack trace and the bug as stated in the first post: auswahl_001