freyta / 7Eleven-Python

A python script to check fuel prices and also lock them in
GNU General Public License v3.0
128 stars 63 forks source link

Update Dockerfile #62

Open beaudeanadams opened 4 years ago

beaudeanadams commented 4 years ago
freyta commented 4 years ago

Hey.

Is there a reason we can't have the APP_VERSION set in the Dockerfile? It would be easier to update the container if there is an update

mxhob1 commented 4 years ago

There is no reason that you cannot set APP_VERSION as an ENV in the Dockerfile also, however it would need manual overriding on runtime as the version changes.