Closed joonas-yoon closed 2 years ago
Merging #56 (ba8230b) into master (4d4fcbf) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #56 +/- ##
=======================================
Coverage 88.37% 88.37%
=======================================
Files 10 10
Lines 671 671
=======================================
Hits 593 593
Misses 78 78
python and pip version is as you can see the following:
$ pip --version
pip 22.1.1 from C:\Python38\lib\site-packages\pip (python 3.8)
you know, CI tells it have only one error but I can not understand that.
style / mypy-py3 (ubuntu-latest, 3.7) (pull_request) Failing after 55s ā mypy-py3 (ubuntu-latest, 3.7)
>>> torchscan/modules/memory.py:228: error: Unsupported operand types for // ("int" and "None") [operator]
but I did not fix it :/
@joonas-yoon I see, so that's because of the latest pip version!
About the CI failure, don't worry, it's unrelated š
What does this PR do?
Related on #55
So I fixed it always read with
UTF-8
encoding.It works fine, in my environment
Before submitting