make iroha-scala work with upcoming version 1.0 of Iroha;
make the library fully asynchonous;
adhere to best practices, in particular in regards to exception handling.
As a secondary aim, we should be able to employ ScalaJS and generate Javascript for the library, possibly making it available in Android platforms. For this reason, we are going to review dependencies and availability of libraries for Android.
Other reasons for a full code review involves best practices such as:
Related: #5 also: https://github.com/frgomes/ed25519-sha3-java/issues/1 also: https://jira.hyperledger.org/browse/IR-386
Branch: http://github.com/frgomes/iroha-scala/tree/RG0001-Code_review
This ticket has three aims overall:
As a secondary aim, we should be able to employ ScalaJS and generate Javascript for the library, possibly making it available in Android platforms. For this reason, we are going to review dependencies and availability of libraries for Android.
Other reasons for a full code review involves best practices such as:
Review dependencies:
Review SBT project structure and plugins
organization
employed in build.sbtcom.lihaoyi:acyclic
pluginReview asynchronous calls:
Review exception handling:
Try/Success/Failure
Try
blocksReview coding standards:
SHA3EdDSAPrivateKeySpec
to simplyPrivateKey
SHA3EdDSAPublicKeySpec
to simplyPublicKey