frgomes / iroha-scala

Scala library for Hyperledger Iroha, a simple distributed ledger. http://iroha.tech
Apache License 2.0
1 stars 0 forks source link

Full code review: dependencies, structure, asynchronous calls #1

Open frgomes opened 5 years ago

frgomes commented 5 years ago

Related: #5 also: https://github.com/frgomes/ed25519-sha3-java/issues/1 also: https://jira.hyperledger.org/browse/IR-386

Branch: http://github.com/frgomes/iroha-scala/tree/RG0001-Code_review

This ticket has three aims overall:

  1. make iroha-scala work with upcoming version 1.0 of Iroha;
  2. make the library fully asynchonous;
  3. adhere to best practices, in particular in regards to exception handling.

As a secondary aim, we should be able to employ ScalaJS and generate Javascript for the library, possibly making it available in Android platforms. For this reason, we are going to review dependencies and availability of libraries for Android.

Other reasons for a full code review involves best practices such as:

Review dependencies:

Review SBT project structure and plugins

Review asynchronous calls:

Review exception handling:

Review coding standards:

frgomes commented 5 years ago

Reminder for myself: invite igor-egorov for reviewing the code.