search

frib-high-level-controls / save-set-restore

save set restore
MIT License
2 stars 0 forks source link

build error on Tab constructor #29

Closed berryma4 closed 8 years ago

berryma4 commented 8 years ago

@jbobnar, I'm merging this to cs-studio/applications: https://github.com/ControlSystemStudio/cs-studio/pull/1789

But, I get an odd error: https://travis-ci.org/ControlSystemStudio/cs-studio/builds/130577706

ERROR] Failed to execute goal org.eclipse.tycho:tycho-compiler-plugin:0.23.1:compile (default-compile) on project org.csstudio.saverestore.ui: Compilation failure: Compilation failure:
[ERROR] /home/travis/build/ControlSystemStudio/cs-studio/applications/saverestore/plugins/org.csstudio.saverestore.ui/src/org/csstudio/saverestore/ui/WaveformDialog.java:[305]
[ERROR] TabPane tabPane = new TabPane(new Tab("Chart", getChartNode(parent)), new Tab("Table", getTableNode()));
[ERROR] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[ERROR] The constructor TabPane(Tab, Tab) is undefined
[ERROR] /home/travis/build/ControlSystemStudio/cs-studio/applications/saverestore/plugins/org.csstudio.saverestore.ui/src/org/csstudio/saverestore/ui/WaveformDialog.java:[305]
[ERROR] TabPane tabPane = new TabPane(new Tab("Chart", getChartNode(parent)), new Tab("Table", getTableNode()));
[ERROR] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[ERROR] The constructor Tab(String, Node) is undefined
[ERROR] /home/travis/build/ControlSystemStudio/cs-studio/applications/saverestore/plugins/org.csstudio.saverestore.ui/src/org/csstudio/saverestore/ui/WaveformDialog.java:[305]
[ERROR] TabPane tabPane = new TabPane(new Tab("Chart", getChartNode(parent)), new Tab("Table", getTableNode()));
[ERROR] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[ERROR] The constructor Tab(String, Node) is undefined
[ERROR] 3 problems (3 errors)
[ERROR] -> [Help 1]
jbobnar commented 8 years ago

Javadoc for TabPane and Tab claims that those missing constructors have only been added in JavaFX 8u40.

I updated the code to use the older constructors and pushed to FRIB repo: https://github.com/frib-high-level-controls/save-set-restore/commit/a58e4ffb03894d84e363bfc3811599f3c6ca6801

berryma4 commented 8 years ago

I pulled it over: https://github.com/ControlSystemStudio/cs-studio/pull/1789 thank you!