fribbels / Fribbels-Epic-7-Optimizer

A gear optimizer for Epic Seven
494 stars 104 forks source link

Add confirmation modal when removing hero with saved builds #209

Open tyopoyt opened 10 months ago

jmferreirab commented 10 months ago

Thank you for the pr @tyopoyt. Please try to add a description and/or visuals of the change to make the PR easier to review.

@fribbels I think this is a nice QoL. Useful when someone manages to accidentally hit remove hero on a hero they have a lot of builds. Likewise, it is not intrusive enough to be annoying since the extra confirmation is only being added to a rarely used button, similar to Github’s delete repository button.

Tested it myself and it's working fine.

image

tyopoyt commented 10 months ago

jmferreirab Ah yeah, I'll include more details in the pr body next time. I may have been somebody who managed to hit delete on a unit with builds I was working on 😅 Was trying to remove a build that I had ruled out