search

fribbels / hsr-optimizer

A Honkai Star Rail optimizer, relic scorer, damage calculator, and various other tools for building and gearing characters
https://fribbels.github.io/hsr-optimizer/
MIT License
236 stars 44 forks source link

[Bug] Character Optimizer Substat Weights Don't Save #331

Closed WolfBungalow closed 3 months ago

WolfBungalow commented 3 months ago

Description

On the Character Optimizer page, the values entered for the "Substat weight filter" and "Top % of weighted relics" are no longer saved and reset to defaults.

Steps to Reproduce

  1. Enter a character optimizer page.
  2. Change the "Substat weight filter" or "Top % of weighted relics" values.
  3. Click "Start optimizer", click "Cancel".
  4. Enter a different character optimizer page.
  5. Return to original character optimizer page. The values will reset.

Expected Behavior

The set values used to save.

Actual Behavior

The values are reset.

Screenshots

image

Additional Information

This issue started with commit 2f5d890. Commit b09d6ea works as expected.

fribbels commented 3 months ago

Thanks for the bug report! Deploying the fix in like 30 mins or so