fribbels / hsr-optimizer

A Honkai Star Rail optimizer, relic scorer, damage calculator, and various other tools for building and gearing characters

https://fribbels.github.io/hsr-optimizer/

MIT License

236 stars 44 forks source link

Fix/infinity% optimality #357

Closed FI00ds closed 3 months ago

FI00ds commented 3 months ago

Pull Request

Description

Added an extra return to score()
Added fakeRelic and generateSubStats
Changed scoreRelicPct and scoreOptimalRelic to use fakeRelic and generateSubStats alongside score() to get more accurate scores
Fixed scoreOptimalRelic to replace infinity% with a more natural behaviour
TODO: scoreRelic currently undervalues future speed rolls, leading to counter-intuitive behaviour of potential

Related Issue

Closes #255

Checklist

[x] I have added commit messages that are descriptive and meaningful.
[x] I have tested the changes locally.
[x] I have reviewed the code changes.
[x] I have ensured the code passes the test suite

Screenshots

fribbels commented 3 months ago

It looks like a bunch of them are now 0% for everything

FI00ds commented 3 months ago

firefox_2024-05-18_06-01-38 Fixed

fribbels commented 3 months ago

Tested and the bugs are gone, thanks for helping out with this!