fribbels / hsr-optimizer

A Honkai Star Rail optimizer, relic scorer, damage calculator, and various other tools for building and gearing characters

https://fribbels.github.io/hsr-optimizer/

MIT License

214 stars 42 forks source link

hotfix: bug in post-calculateBaseMultis set effects not activating #387

Closed fribbels closed 1 month ago

fribbels commented 1 month ago

Pull Request

Description

Fixing a bug where Crit sets were applying before calculateBaseMultis. This meant that in some scenarios, salsotto for example would not activate for aventurine unless his base CR was > 50%.
Now we calculate in this order, where crit passives and boost passives from sets are calculated in calculatePostBaseSetEffects, which gain the benefit of being after calculateBaseMultis so that aventurine's trace can apply first.

    calculateComputedStats(c, request, params)
    calculateBaseMultis(c, request, params)
    calculatePostBaseSetEffects(c, request, params)
    calculateDamage(c, request, params)

Related Issue

Checklist

[x] I have added commit messages that are descriptive and meaningful.
[x] I have tested the changes locally.
[x] I have reviewed the code changes.

Screenshots