[Bug] Check all conditionals for on-hit effects and exclude from combat stats

fribbels / hsr-optimizer

A Honkai Star Rail optimizer, relic scorer, damage calculator, and various other tools for building and gearing characters

https://fribbels.github.io/hsr-optimizer/

MIT License

214 stars 42 forks source link

Open fribbels opened 1 month ago

fribbels commented 1 month ago

Some buff effects are not actually combat stats, but rather trigger only on hit without adding to the character's stats. For example, crit rate buffs from Wastelander. This means our set activation might be incorrect in cases like Rutilant/etc

Revisit all the conditionals, figure out which ones are on-hit effects and which ones are not, then patch the damage calculations to account for this disparity. Potentially introduce a third view for Basic / Combat / On-Hit?