search

fribbels / hsr-optimizer

A Honkai Star Rail optimizer, relic scorer, damage calculator, and various other tools for building and gearing characters
https://fribbels.github.io/hsr-optimizer/
MIT License
208 stars 42 forks source link

[Feature] Blur / display skeleton components while DPS score is loading, calculate DPS score async #421

Open fribbels opened 3 weeks ago

fribbels commented 3 weeks ago

Motivation

DPS score calculations currently lag the page because the simulations take a while to process

Related: https://github.com/fribbels/hsr-optimizer/issues/420

Goal

Use some skeleton components https://ant.design/components/skeleton/ to hide the score related components while they're loading async. Unhide/unskeleton them when the scores are comoplete

Components:

image
fribbels commented 3 weeks ago

Prototyped a temporary skeleton component but it actually looks pretty jarring, will need some UI discussion about what to do https://github.com/fribbels/hsr-optimizer/pull/422

image

Probably better to just make the sims faster