fribbels / hsr-optimizer

A Honkai Star Rail optimizer, relic scorer, damage calculator, and various other tools for building and gearing characters

https://fribbels.github.io/hsr-optimizer/

MIT License

209 stars 42 forks source link

feat: relic count #429

Closed FI00ds closed 3 weeks ago

FI00ds commented 3 weeks ago

Pull Request

Description

Added display for total relic count and filtered relic count

Related Issue

Closes #424

Checklist

[x] I have added commit messages that are descriptive and meaningful.
[x] I have tested the changes locally.
[x] I have reviewed the code changes.

Screenshots

firefox_2024-06-12_12-35-56

fribbels commented 3 weeks ago

I think this is probably the wrong solution to the problem, we don't need a custom component when the grid library already provides the functionality - https://www.ag-grid.com/javascript-data-grid/row-pagination/

Changing this to use grid options instead will let us minimize complexity

            pagination={true}
            paginationPageSizeSelector={false}
            paginationPageSize={2000}

fribbels commented 3 weeks ago

Updated to:

FI00ds commented 3 weeks ago

the custom component was so that you can see both how many relics pass the filter and how many you have in total at the same time since pagination only shows the number that currently pass the filter