issues
search
fribbels
/
hsr-optimizer
A Honkai Star Rail optimizer, relic scorer, damage calculator, and various other tools for building and gearing characters
https://fribbels.github.io/hsr-optimizer/
MIT License
209
stars
42
forks
source link
fix: relics tab invalid upgrades bug
#434
Closed
fribbels
closed
3 weeks ago
fribbels
commented
3 weeks ago
Pull Request
Description
Fix the relics tab bug where invalid/suboptimal stats were being used for displaying on hover.
Added the correct filtering logic for valid upgrades, and the weight comparison for new substats should be based on the max score not min score.
Fixed Firefly's sim main stats, added Fire DMG for gallagher sphere
Related Issue
433
Checklist
[x] I have added commit messages that are descriptive and meaningful.
[x] I have tested the changes locally.
[x] I have reviewed the code changes.
Screenshots
Pull Request
Description
Related Issue
433
Checklist
Screenshots