Added All and None buttons to character select screen.

fribbels / hsr-optimizer

A Honkai Star Rail optimizer, relic scorer, damage calculator, and various other tools for building and gearing characters

https://fribbels.github.io/hsr-optimizer/

MIT License

209 stars 42 forks source link

Added All and None buttons to character select screen. #445

Closed WolfBungalow closed 2 weeks ago

WolfBungalow commented 2 weeks ago

Description

I added "All" and "None" buttons to the character selection screen. Please review my work, as I am unsure if I did it correctly. These buttons work with the Element and Path filters, only affecting the visible characters.

Related Issue

Closes #444

Checklist

[x] I have added commit messages that are descriptive and meaningful.
[X] I have tested the changes locally.
[X] I have reviewed the code changes.

Screenshots

fribbels commented 2 weeks ago

Changing the buttons for clarity:

fribbels commented 2 weeks ago

Thanks for the help on this, sending to beta

WolfBungalow commented 2 weeks ago

I had kept the min width to take from the textbox width and still look nice at window min width. Here is what it looks like right now if you reduce the window width to minimum. There is overflow off the window.