search

fribbels / hsr-optimizer

A Honkai Star Rail optimizer, relic scorer, damage calculator, and various other tools for building and gearing characters
https://fribbels.github.io/hsr-optimizer/
MIT License
250 stars 43 forks source link

[Bug] Optimizer Shows Incorrect Stats #447

Closed yeanshu closed 3 months ago

yeanshu commented 3 months ago

Description

Characters without no Planar Ornaments equipped have incorrect stats in Optimizer tab, this in turn results in incorrect damage calculations.

If either Sphere or Rope is equipped, stats are correct. However, equipping relic sets makes no difference.

Steps to Reproduce

  1. Start optimizer for any character with no relics equipped
  2. The top/current row in the results table has incorrect stats.

Expected Behavior

Optimizer tab should show stats consistent with those in game, and with the Characters tab.

Actual Behavior

Optimizer tab shows incorrect stats. Testing with other characters, the displayed ATK stat is overstated by roughly 12% of the base ATK. As seen below, Ratio's ATK is shown as 1827, when it actually is 1670, a difference of 157. The base ATK of Ratio/Cruising in the Stellar Sea is 1305, and 12% of that is also 157.

Screenshots

Optimizer Tab with no relics image

Character Tab with no relics image

In game with no relics image

Optimizer Tab with Sphere equipped image

fribbels commented 3 months ago

@yeanshu Thanks for the bug report! The fix has been deployed now in https://github.com/fribbels/hsr-optimizer/pull/448