feature: new logic for ability type buffs

[fribbels]

Pull Request

Description

• Moved buff logic to calculateBuffs
• Rewrote the buff logic to handle ability dmg type switching: Yunli, Topaz, Acheron

/*
 * These methods handle buffing damage types for characters who have dynamic ability types. For example Yunli's FUA
 * can be both ULT and FUA dmg so buffs must be applied to both without overlapping.
 *
 * The flags are bitwise, so the usage should be:
 * buffAbilityDmg(x, BASIC_TYPE | SKILL_TYPE, 1.00, condition)
 *
 * And changing characters ability type should be:
 * x.BASIC_DMG_TYPE = BASIC_TYPE | FUA_TYPE
 */

• Refactored all conditionals to use the new logic
• Fixed a few bugs along the way
  • Yunli no longer gets double buffed by salsotto
  • Yunli now correctly benefits from FUA vulnerability
  • Herta skill 50% hp buff is now correctly 20%

Related Issue

Checklist

• [x] I have added commit messages that are descriptive and meaningful.
• [x] I have tested the changes locally.
• [x] I have reviewed the code changes.

Screenshots