[Feature] Adjust portrait crop logic to work for both character and sim scoring portraits

fribbels / hsr-optimizer

A Honkai Star Rail optimizer, relic scorer, damage calculator, and various other tools for building and gearing characters

https://fribbels.github.io/hsr-optimizer/

MIT License

209 stars 42 forks source link

[Feature] Adjust portrait crop logic to work for both character and sim scoring portraits #459

Open fribbels opened 1 week ago

fribbels commented 1 week ago

Motivation

Currently the character scorer & sim scorer portraits have different dimensions, which means the user will have an incorrect crop for one of them (sim scoring)

Goal

Unsure what the fix is yet but we should be able to handle both types of crop

Either 1, have two different crop dimensions
2, always make sure the smaller one fits into the bigger one and they both fit in the original image
3, zoom out and make sure it doesn't exceed image bounds