friciwolf / Rocket

Application launcher for KDE Plasma.
https://store.kde.org/p/1507169/
GNU General Public License v3.0
34 stars 0 forks source link

installer.sh should prompt the user to append `$HOME/.local/bin` to `PATH` #3

Closed grtcdr closed 3 years ago

grtcdr commented 3 years ago
chmod +x rocket
mkdir -p ~/.local/bin/
cp rocket ~/.local/bin/rocket

A good chunk of people don't have ~/.local/bin in their PATH, so running rocket will notify them that no such file exists on the system. So you might want to consider echoing a warning that prompts the user to add that path to the PATH environment variable.

friciwolf commented 3 years ago

I think I could add a warning to the installer script, however a better solution would be to not only notify the user, but to also add ~/.local/bin to their PATH upon installation, which I think goes beyond my scripting abilities. An alternative would be to place the executable to /bin directly, but I somehow like the idea of local installations only.

grtcdr commented 3 years ago

I'm not sure if you are familiar with Rust and its package manager, cargo.

But upon installation, cargo notifies you to add its bin directory to your path, so you can run those programs you installed.

The gem (for Ruby) package manager also shares this trait.

Not every shell operates the same so appending it to PATH of the user's shell dotfile is what I'd consider a headache.

friciwolf commented 3 years ago

I'm not sure I follow but you're proposing to package the binaries as a gem (or sth. similar) just like colorls does? If that solves the issue you've described, it's a solution I'd be happy with :)

grtcdr commented 3 years ago

No, I was simply telling you that it's perfectly fine to settle with just notifiying the user to add the path to PATH.

friciwolf commented 3 years ago

Alright I see! If you know how it's done (you seem to know more things on this area than me), could you make a pull request? Now my focus would be on different things, however your feature would definitely be helpful for new-coming users!