Fix errors, add new colors and basic auth

[pforrmi]

Changes:

• Update espressif32 to 3.5.0 & fix async webserver
• Changed led basic color to white. Led breathing at ready state changed to static. Led ring blinks blue at starting up. Important: New color need to be defined at .pio -> libdeps / esp32doit-devkit-v1 -> Adafruit Fingerprint Sensor Libary -> Adafruit_Fingerprint.h
• Fingerprint confirmation turn green color on for 1 second
• Simple basic web auth added so the UI is no free accessible in the network (maybe the credentials should better be configurable at web ui?!)

I'm open for adjustments if some changes may are not useful or may not added correctly.

[frickelzeugs]

Hi @pforrmi,

thanks for your PR. You're adressing multiple issues in your PR:

1. Compile errors

2. led color schema

3. authentication

4. was already mentioned and adressed by some other users comments and PR. I just commited a fix yesterday, which doesn't need to reference a unofficial build of AsyncElegantOTA by using lib_ldf_mode = deep+. I find this the most charming option. Of course we still have to nail the plattform version to 3.5, but I will remove this as soon as a new official library version of the async web server is released containing a fix.

2.: I don't want to change the color scheme of the led because of 2 reasons:

• there are already a bunch of builds out there (including mine), that don't support the new green color. The manufacturer of the sensor has been adding the green LED only a few months ago. All devices previously sold only had a red and blue LED and were therefore limited to red, blue and purple (also the original one sold on Adafruid is still a model without green). Of course, I personally would have liked it better if the LED glowed green when authentication was successful, but unfortunately, as I said, that didn't work when i developed this. A conditional dual implementation to support both types would be a solution (although afaik unfortunately you cannot ask the sensor whether it supports the additional colors or not), so you would have to provide an additional option for configuring the color scheme in the UI to let the user give us this information. I am unsure whether that is worth the effort, especially since it unnecessarily complicates the instructions of what the color codes mean in the docs.
• if find it quite hacky to have to modify locally cached dependencies (the Adafruit lib) to support those additional colors and without this manual step the build won't work. But, regardless of FingerprintDoorbell, it would be great to have those new colors in the official lib anyway. Would you please file a PR to the library?

3.: Authentication is a good idea! I already had this in mind during development, but then pushed it back due to time constraints. But hard coding this option and also the credentials isn't an option for me, because some users don't want to mess with VS Code to and just using the binaries. So, the basic auth thing should be at lease configurable through the webui (turn basic auth on/off and also the ability to change the password (and user?)). Would you like to reduce your PR to this aspect and fully implement this feature?

Viele Grüße, Tobias

[pforrmi]

Thanks for the long and detailed reply!

Pull request due to led colors done: https://github.com/adafruit/Adafruit-Fingerprint-Sensor-Library/pull/119 We'll see if anything happens here. If it will positiv, maybe the change of basic color setting make sense. I'm agree with you cause the manual edit of the library is not very user friendly.

I'm not sure if I'm able to implement the authentication to make it configurable through the ui. Maybe for this my skills are not good enough 😃 At the moment I just can offer the hard coded one.

Looking forward to have at some time the best self-made fingerprint sensor for our homes 👍 (It's already pretty nice at this state!)