search

friction2d / friction-icon-theme

Friction Icon Theme
Creative Commons Attribution Share Alike 4.0 International
1 stars 2 forks source link

Icon Theme Discussion #4

Open adambelis opened 5 months ago

adambelis commented 5 months ago

I ma tring to fixe few icons i noticed that svg are on 25x25 grid . this is slightly unusual it usually goes 16 32 64 alternatively 16 24 32 48 68 128 Is this a mistake in files or intended and should be kept same ?

rodlie commented 5 months ago

What are you trying to fix?

The original icons from enve are random, when I need new icons or replace something I use https://github.com/Shrinks99/blender-icons (should now use https://ui.blender.org/icons)

Note that Friction does not use the SVG's, they are just source for our icon theme.

adambelis commented 5 months ago

circle and rectangles are way off in size (i know circle should be slightly bigger, but this is way too much). image

Note that Friction does not use the SVG's, they are just source for our icon theme.

Is that autogenerateed or that needs to be done by hand ?

rodlie commented 5 months ago

Ok, hold on doing anything yet, can be a good excuse to replace some old icons ;)

Is that autogenerateed or that needs to be done by hand ?

We have a script that generates/update the icon theme from the SVG's (uses inkscape).

adambelis commented 5 months ago

image

well thtas kind of rabbithole i strted falling to . Fricon does not have that many icons copper to inkscape +450 :D

rodlie commented 5 months ago

We could also take icons from Inkscape (I assume they are CC?), but we have kind of "standardized" on the blender icons (at least for new icons), so I prefer we use icons from them as much as possible (to keep a consistent theme).

adambelis commented 5 months ago

Yes, all Inkscape icons are CC . But Inkscape has more icon sets. Hicolor old with colors (depricated) Hicolor symbolic (single color) Multicolor (currently maintained mostly by me) tango (colorful depricated i am pushing for removing it soon ) dash (new single color theme). defoult multicolo theme : image

Not sure if this will work for fricon since this icons are design in specific way it has 3+1 color every color is used contextually. (pink = type, procedural shape , Green create new , blue-style color ) and this color case controlobale by CSS from UI https://wiki.inkscape.org/wiki/Creating_a_multicolor_icon

bascaly its a mess :D

https://gitlab.com/inkscape/inkscape/-/tree/1.4.x/share/icons

sometimes you can get away with using icons from other software but you need to be carful if it fit you context and rest of icons . Blender is kind of crazy coz lots of the icons (not all) are made in bleder and are not svgs

rodlie commented 5 months ago

I started a new repo for the v1 icon theme: https://github.com/friction2d/friction-icon-theme

adambelis commented 5 months ago

should i try commit there ?

rodlie commented 5 months ago

Yes, that would be nice, we will use this theme for 0.9.6 (I added the old icons to avoid breaking anything, see hicolor/scalable/legacy folder).

Just put the icons in the hicolor/scalable/actions folder.

rodlie commented 5 months ago

Friction branch https://github.com/friction2d/friction/tree/icon-theme now uses the icon-theme (the build branch).

rodlie commented 5 months ago

Better now? :)

friction-toolbox

adambelis commented 5 months ago

now its too big and stroke is thicker then circle .

rodlie commented 5 months ago

Then feel free to modify: https://github.com/friction2d/friction-icon-theme/tree/main/hicolor/scalable/friction-tools ;)

I need to prepare other things for the release.