Icons in 'NoInterpolation' need a SVG source

[rodlie]

We don't have any sources for these icons, replace with something similar.

[adambelis]

can you add screan shot wich are thies ?

[rodlie]

https://github.com/friction2d/friction-icon-theme/tree/main/noInterpolation

I'm on a Mac at the moment, but I did have a very old build:

Yeah, not that hard to replace, just never did :)

[adambelis]

so they should stay 10x10 ? or should i switch to 16x16

[rodlie]

10x10 is not a requirement, don't know why they are 10x10 in the first place :)

[rodlie]

Home and just tested the icons. We do need to make some size adjustments.

We probably need a guideline/template for padding in the SVG's.

[rodlie]

Better:

https://github.com/friction2d/friction-icon-theme/blob/main/hicolor/scalable/friction/graph_property_2.svg

But I still don't think it works with the colored background.

Regarding the icon size, I will make _2 versions of the SVGs that have identical padding/size as the old icons to avoid padding issues in 0.9.6. Will fix it properly for v1.

[adambelis]

hmm .. i think this is kind of hacky implantation for checkboxes on that graph . that checkbox color is set 12x12 px wich is probably custom set for that old 10x10 format . but my 16x16 ixon seemts to be render with 18x18 px. But i agree that that icons for grap seems to chunky for that small row

I am ok to make it to if to 10x10 pixels just you need to know that is kind of sort of hacky special case. since other icons seem to render 16x16px .

[rodlie]

I'm not blocking 0.9.6 just because of icons ;) I will just add identical padding in the SVGs and call them _2. Will refactor this for v1.

[adambelis]

But I still don't think it works with the colored background.

I agree i think they need a second black outline

[rodlie]

Yes, that would probably work.

[adambelis]

I'm not blocking 0.9.6 just because of icons ;) I will just add identical padding in the SVGs and call them _2. Will refactor this for v1.

i would not even suggest that this are just improvements not critical things

[rodlie]

Good enough™ (will try to adjust the background fill rect size in the code, but that's not an icon issue)

[adambelis]

We can iterate later :)