Only show usable animators in graph

[rodlie]

This is a proposed solution for issue #176.

Introduces a new "isGraphSelected" function for boxes and "prp_isParentBoxGraphSelected" for properties. This function is used by the graph to figure out which animators are usable or not, the state is controlled by the canvas. if "isGraphSelected" is false then the box should be considered removed and the animator connected to the box should be ignored, we do not remove it since that breaks undo.

Binaries: https://sourceforge.net/projects/friction/files/0.9.6-629e18e8/

Fix #176

[adambelis]

edit: i still can replicate same bug . maybe i am testing wrong version ? https://github.com/friction2d/friction/commit/1b2af3b4

[rodlie]

i still can replicate same bug . maybe i am testing wrong version ?

0.9.6-629e18e8

I think you are using wrong build.

[adambelis]

ok finaly rocking correct build. This fixes the problem but introduce new one. If delete object graph disperes but if you undo you can never get it back for any property of that object

[rodlie]

if delete object graph disperes but if you undo you can never get it back for any property of that object

Click on the box.

[adambelis]

https://github.com/friction2d/friction/assets/50795097/26a6a726-52c9-442e-8e2b-91256a5ff12e

[rodlie]

As said, click on the box.

Undo does not change states, so the graph does not update.

[adambelis]

I did clikec the vox it's doing nothing

[rodlie]

You do not click the box (the eclipse object) in the video.

[adambelis]

When you say box you mean small grap icon next to property ? I am clicking it but you cannot see that since that but just does not work if you mean different box not sure which one :D

[rodlie]

Lost in translation ;) I mean the object/box as in the circle/rectangle/path whatever.

https://github.com/friction2d/friction/assets/34516798/d8b60799-020d-4b13-92ca-771d145d1de1

[rodlie]

And before you say it, yes this is not how it worked. But that's because the graph animator was never removed. The undo "update" is a different issue (that I will look into).

[adambelis]

hmm.. honesty i dislike this system now you need to enable cruvs in 3 places (two was already too much) . I think keeping bug is better then this behavior :D

[rodlie]

If you delete a 'box' and undo you have to click it to get the animators back in the graph, not that hard. When I fix the undo state nothing will have changed.

[adambelis]

ah ok i misunderstood this needs to be done for all objects. in that case this is ok soluition

[rodlie]

So, will delay this until the next version. It's a workaround, I would rather fix this properly.

Will keep the PR open just as a reminder (or fallback).