Closed k-nut closed 8 years ago
I think this should be actually good to merge now. I published this to testpypi and the install seems to work fine. It took me some attempts to get it right so on testpypi this is version 0.2.3
now, on pypi it would of course be published as 0.2.0
.
Does this look good to you @vitorbaptista so that we could merge this and I could publish the package to PyPi?
@amercader or @brew can you also check that the package meets any requirements for CKAN packages that get published? Thanks.
@vitorbaptista thank you again for all your feedback! Is there anything else that I should change?
Also: Should I rebase the commits into a single one?
FYI: CKAN 2.6 will drop support for Python 2.6 [1]. This isn't in the docs yet, but hopefully should be before release. As this extension is due to support 2.4+, it should probably support Python 2.6, though.
[1] https://lists.okfn.org/pipermail/ckan-dev/2016-January/009608.html
I'll rewrite the tests to not use any of the unittest features that were only introduced in 2.7 then.
@brew it looks like some of the failures with 2.6
come from one line in the ckan/tests/helpers.py
from upstream ckan. Is ckan/ckan
actually continually tested against version 2.6
?
https://travis-ci.org/ckan/ckanext-datapackager/jobs/135555393#L1830
CKAN on master (what will become CKAN 2.6) doesn't support Python 2.6.
OK, so there is a bigger problem in this. datapackage-py, which is of course used by this, only supports python 2.7+
and actually fails when run under 2.6. See trace.
How should we handle this? Say that this extenstions supports ckan 2.4+
but only when run with python 2.7
?
@k-nut can we just set this for Python 2.7 and above, and be done with it. I think working on 2.6 support is a waste of time.
@pwalsh sure. I don't have strong feelings about what version this supports. Just reverted the commit that tried to build on 2.6.
Merged :+1:
This fills out the
setup.py
with the required information and adds theMANIFEST.in
file that is needed for the template files and the README.Most of this is stolen from https://github.com/ckan/ckanext-showcase/ and https://github.com/okfn/ckanext-s3filestore
This is still work in progress that I will finish up on Monday but I wanted to give @vitorbaptista the chance to look at this already.
I'm not sure about putting me as author but Brook did the same in the other packages so I just followed his example.