Bug in lookup for source_id and publisher_id, IF source.url is not unique

frictionlessdata / data-quality-cli

CLI for creating databases for Data Quality Dashboards.

https://github.com/okfn/data-quality-dashboard

MIT License

19 stars 1 forks source link

Bug in lookup for source_id and publisher_id, IF source.url is not unique #2

Closed pwalsh closed 8 years ago

pwalsh commented 9 years ago

Code assumes source.url will always be unique (in reality, it should). But, if it is not, then the current lookup when writing results will get the first match and use that source_id and publisher_id, which could be wrong.

pwalsh commented 8 years ago

This was a bug I raised before many other people touched the code. I guess it is still relevant, but depends on the changes made via #4 - so please check.