frictionlessdata / datapackage-js

A JavaScript library for working with Data Package.
http://frictionlessdata.io/
MIT License
43 stars 15 forks source link

Latest profile update causes validation of resource erroring at dialect/description #105

Closed ghost closed 6 years ago

ghost commented 6 years ago

Hi @roll With the profile update required before last release, we now receive a validation error for dialect in Data-Curator Descriptor validation error: Missing required property: description at "/dialect" in descriptor and at "/properties/dialect/required/0" in profile

I suspect this is due to the profile update reflected in spec here:

     ...
      "required": [
        "description"
      ],
      "properties": {
        "description": {
          "required": [
            "delimiter",
            "doubleQuote"
          ],

Sorry for missing this, but I'm not sure what this means:

roll commented 6 years ago

@mattRedBox TBH I'm not sure why this change has happened - https://github.com/frictionlessdata/specs/commit/b5a8daf68584088408d29ee4251176cc800e9b89 - and what is a description field.

http://frictionlessdata.io/specs/csv-dialect/

ghost commented 6 years ago

Thanks for raising this @roll

roll commented 6 years ago

@mattRedBox For now, I've released both py/js libs with rolled profiles back.

ghost commented 6 years ago

awesome - thanks @roll