search

frictionlessdata / datapackage-js

A JavaScript library for working with Data Package.
http://frictionlessdata.io/
MIT License
42 stars 15 forks source link

Rename DataPackage to Package #81

Closed rufuspollock closed 6 years ago

rufuspollock commented 7 years ago

As class names shouldn't we have

EITHER Package and Resource

OR DataPackage and DataResource

At the moment we DataPackage and Resource.

roll commented 7 years ago

Ruby implementations has Package. But for DataPackage and Resource I suppose there are historical reasons (it was named like this for a while) cc @pwalsh @akariv @amercader

rufuspollock commented 7 years ago

I'd vote for Package and Resource.

pwalsh commented 7 years ago

It is just historical. Data Resource only really became a fully formed concept in recent months. I think we should be consistent Package / Resource or DataPackage / DataResource, but I am not opinionated on which one. Whatever @roll decides.

roll commented 7 years ago

Package and Resource sounds great. It was a little bit confusing to have datapackage module, DataPackage class and data_package (explicit dp) instance in documentation.

rufuspollock commented 7 years ago

@roll I agree!