frictionlessdata / datapackage-js

A JavaScript library for working with Data Package.
http://frictionlessdata.io/
MIT License
43 stars 15 forks source link

Fix broken build #99

Closed vitorbaptista closed 6 years ago

vitorbaptista commented 6 years ago

The build is currently broken (https://travis-ci.org/frictionlessdata/datapackage-js/builds/327257239):

The relevant part of the logs is:

10 01 2018 14:48:27.470:INFO [karma]: Karma v1.7.1 server started at http://0.0.0.0:9876/
10 01 2018 14:48:27.486:INFO [launcher]: Launching browser jsdom with unlimited concurrency
10 01 2018 14:48:27.492:INFO [launcher]: Starting browser jsdom
10 01 2018 14:48:29.278:INFO [Node.js (linux; U; rv:v8.9.4) AppleWebKit/537.36 (KHTML, like Gecko)]: Connected on socket Dk8eqXAauydzzngJAAAA with id 91000625
Node.js (linux; U; rv:v8.9.4) AppleWebKit/537.36 (KHTML, like Gecko) ERROR
  Super expression must either be null or a function, not object
  at test/karma.opts:8098

This message seems related to React. I tried running the tests locally and I can reproduce the error, even going as far as 20 commits back, on versions that did pass on Travis. This means that probably the error is caused by updates on a third-party library. We just need to figure out which.

Unfortunately, we don't know the exact dependencies' versions used on the old test runs, which would make it easier to pinpoint what has changed. After this is fixed, we should print the package-lock.json contents during the test run.

(cc @roll)