frictionlessdata / datapackage-php

A php library for working with Data Package.
MIT License
10 stars 10 forks source link

should refactor the validators hack for table schema url format fields #14

Closed OriHoch closed 7 years ago

OriHoch commented 7 years ago

there is a problem with the json schema validator and the handling of file paths in the resources data property.

currently it was fixed with a simple hack that prepends file:// to the data field

need to review and look for possible problems with this hack, then fix it properly

also, it should really be inside the datapackage class to allow extensibility

OriHoch commented 7 years ago

this problem was introduced in #13

pwalsh commented 7 years ago

@OriHoch is this still a problem with the latest spec changes (rc2)? cc @roll

OriHoch commented 7 years ago

this is still a problem, I opened a PR on specs: https://github.com/frictionlessdata/specs/pull/480

OriHoch commented 7 years ago

fixed in v0.1.4 - removed the hack as it's not neccessary for latest spes