Insure "path" is an array.

frictionlessdata / datapackage-php

A php library for working with Data Package.

MIT License

10 stars 10 forks source link

Insure "path" is an array. #28

Closed dsantuc closed 7 years ago

dsantuc commented 7 years ago

I've added checks to see if "path" is an array in the relevant places. Not sure if it's ultimately "correct" but it worked with the data packages I was using with string "path" properties.

coveralls commented 7 years ago

Coverage decreased (-0.1%) to 87.992% when pulling 62ce08fa67e47e7be19683f1e9fea087428300bb on GnaritasInc:pathfix into 017fa91f7293661720bd25d56b52a731ab6e3c15 on frictionlessdata:master.

OriHoch commented 7 years ago

looks good, thanks!

travis does a check for style which failed, see here - the style check is done on php 7.1 only

You can see all Php versions passed, except 7.1 - which it's safe to assume style check failed

Usually, I ignore styling while developing, and when finished I run:

composer style-fix

Anyway, I ran it and will merge the PR.. Thanks!