Running dpp with nonexistent dataset reference exists silently

[jbothma]

In order to submit an issue, please ensure you can check the following. Thanks!

• [x ] Declare which version of Python you are using (python --version)

• [ x] Declare which operating system you are using

• python 3.6.4

• datapackage-pipelines 1.5.4

• operating system: iinux (arch)

Running

GOBBLE_AUTH_TOKEN=mytoken dpp run ./2017-18/national/estimates-of-national-expenditure-south-africa-2017-18

outputs

INFO    :Main                            :Skipping redis connection, host:None, port:6379
INFO    :Main                            :RESULTS:

and exists with exit code zero giving no feedback that something went wrong or what went wrong.

[OriHoch]

this is the relevant code - https://github.com/frictionlessdata/datapackage-pipelines/blob/master/datapackage_pipelines/cli.py#L110

I think that we need to add a condition there, something like -

if len(results) == 0:
  exitcode=1

[OriHoch]

also, output a friendly error message -

no results, please check the pipeline id / processor names

[OriHoch]

also, you can add this condition to our cli exit codes test.. https://github.com/frictionlessdata/datapackage-pipelines/blob/master/tests/exit-codes/test_cli_exit_codes.sh

[akariv]

Good suggestion. On it.