search

frictionlessdata / datapackage-pipelines

Framework for processing data packages in pipelines of modular components.
https://frictionlessdata.io/
MIT License
119 stars 32 forks source link

SyntaxError in specs.py #141

Closed loleg closed 6 years ago

loleg commented 6 years ago

In a fresh install of dpp on Python 3.5 from PyPi (1.7.1) or GitHub, I get this error:

    specs: Iterator[PipelineSpec] = find_specs(root_dir)
         ^
SyntaxError: invalid syntax

https://github.com/frictionlessdata/datapackage-pipelines/blob/53d29c20c5968d11e9c5bb7bb53f185b66cf8af7/datapackage_pipelines/specs/specs.py#L59

It looks to me like Type Hinting using the typing helper is not compatible with my version of Python. It would be good to state the minimum requirement in the README.

loleg commented 6 years ago

I now see that the README does mention Python 3.6, but not clearly as a requirement to use the library.

akariv commented 6 years ago

Hey, if you're up to it, could you send a PR with better wording for the README?

Thanks!

On Fri, Aug 17, 2018, 08:23 Oleg Lavrovsky notifications@github.com wrote:

I now see that the README does mention Python 3.6, but not clearly as a requirement to use the library.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/frictionlessdata/datapackage-pipelines/issues/141#issuecomment-413780908, or mute the thread https://github.com/notifications/unsubscribe-auth/AAQMdWdkE0oHBxuc4PqIwgTGNNxuhFwZks5uRm9ygaJpZM4WBEKx .