search

frictionlessdata / datapackage-py

A Python library for working with Data Packages.
https://frictionlessdata.io
MIT License
191 stars 43 forks source link

Remove escapeChar from DEFAULT_DIALECT #201

Closed dahlbaek closed 6 years ago

dahlbaek commented 6 years ago

According to the CSV dialect specification, the escapeChar option should not be set by default.

Fixes #200

dahlbaek commented 6 years ago

The checks now pass, but the behaviour conflicts with what is written in the profiles. I think I may have attacked this the wrong way. The real conflict seems to be between what is written on the specification page

escapeChar - specifies a one-character string to use for escaping (for example, \), mutually exclusive with quoteChar. Not set by default

and what is written in the profile:

"escapeChar": {
      "title": "Escape Character",
      "description": "Specifies a one-character string to use as the escape character.",
      "type": "string",
      "default": "\\",
      "examples": [
        "{\n  \"escapeChar\": \"\\\\\"\n}\n"
      ]
    }
dahlbaek commented 6 years ago

Closing to move to a non-master branch in my fork...