search

frictionlessdata / datapackage-py

A Python library for working with Data Packages.
https://frictionlessdata.io
MIT License
189 stars 44 forks source link

Remove escapeChar from DEFAULT_DIALECT #203

Closed dahlbaek closed 6 years ago

dahlbaek commented 6 years ago

According to the CSV dialect specification, the escapeChar option should not be set by default.

escapeChar - specifies a one-character string to use for escaping (for example, \), mutually exclusive with quoteChar. Not set by default

Closes #200 Continued from #201

dahlbaek commented 6 years ago

Related to this PR, there was a conflict between the written spec and the JSON schema for CSV dialect regarding the escapeChar option, see issue frictionlessdata/specs#576. The issue was closed with frictionlessdata/specs#577, and @rufuspollock pointing out that:

Yes, we should go with the written spec rather than the JSON schema which means the escape character is not set by default.

roll commented 6 years ago

@dahlbaek Sorry for the long wait. It looks good. Thanks for the work on the lib and the specs!