search

frictionlessdata / dpm-js

[DEPRECATED] Please use https://datahub.io/docs/features/data-cli
109 stars 18 forks source link

Ignore data resource #50

Closed waylonflinn closed 8 years ago

waylonflinn commented 8 years ago

Allows downloading packages with inline data resources.

fixes #49

rufuspollock commented 8 years ago

@waylonflinn thanks for this - patch looks good and a nice proper test (though it would be good to move that example package perhaps into the test directory in this repo so we do not have breakage later if you move stuff).

I'm going to merge this now but request that you then add a minimal datapackage example into the fixtures directory https://github.com/okfn/dpm/tree/master/test/fixtures and update the test to use it.

waylonflinn commented 8 years ago

Thanks, I was concerned about that as well. It wasn't clear to me how to get the test to use local data. I'm sure I'm just overlooking the relevant example. Suggestions or pointers appreciated.

rufuspollock commented 8 years ago

@waylonflinn for get command testing with local will be tough. So suggest here was still to use a remote url but use one that we have committed into the test/fixtures directory of this package. does that make sense?

waylonflinn commented 8 years ago

now I get it. thanks for clarifying. will put a PR together tomorrow.