frictionlessdata / frictionless-ci

Data management service that brings continuous data validation to tabular data in your repository via Github Action
https://repository.frictionlessdata.io
MIT License
36 stars 12 forks source link

Validation report does not include info on resources with inline data #18

Closed olejandro closed 2 years ago

olejandro commented 2 years ago

Overview

https://github.com/MaREI-EPMG/ireland-carbon-budget-scenarios-2021/ data package includes two resources consisting of inline data, series and scenarios. It seems that they are excluded from the validation report: https://repository.frictionlessdata.io/report/?user=MaREI-EPMG&repo=ireland-carbon-budget-scenarios-2021&flow=frictionless&run=1295757932


Please preserve this line to notify @roll (lead of this repository)

roll commented 2 years ago

Thanks! I'll investigate

roll commented 2 years ago

Hi @olejandro,

It must be fixed now. Can you please try and let me know if it's not?

olejandro commented 2 years ago

Hi @roll,

Thanks! I've realised that an older version of frictionlessdata/repository was used for validation, so I've changed it to v1.0.0. However the report won't load now. Looking at the browser console it seems that some React components are failing:

Uncaught TypeError: text is undefined
...
The above error occurred in the <ReportTask> component:

ReportTask@webpack://frictionlessComponents/./src/components/ReportTask.tsx?:31:46
div
Report@webpack://frictionlessComponents/./src/components/Report.tsx?:34:23
div
div
Workflow@webpack://frictionlessComponents/./src/components/Workflow.tsx?:35:33
...
Uncaught (in promise) Error: A cross-origin error was thrown. React doesn't have access to the actual error object in development. See https://reactjs.org/link/crossorigin-error for more information.
roll commented 2 years ago

@olejandro Sorry for that. The report now works - https://repository.frictionlessdata.io/report/?user=MaREI-EPMG&repo=ireland-carbon-budget-scenarios-2021&flow=frictionless

olejandro commented 2 years ago

Thanks a lot, @roll - also all the resources (incl. inline) are now listed