search

frictionlessdata / frictionless-ci

Data management service that brings continuous data validation to tabular data in your repository via Github Action
https://repository.frictionlessdata.io
MIT License
37 stars 12 forks source link

worflow typo correction. Include k #5

Closed gabrielbdornas closed 3 years ago

gabrielbdornas commented 3 years ago

Overview

Hello guys!!! First of all congratulation on the amazing work you are doing here. We've been using frictionless specifications a lot and now the possibility to validate data in our GitHub repositories is quite impressive. Tanks a lot!

Yesterday reading the documentation I've found a little typo that I want to suggest a correction. As a follow these instructions in one project online validation didn't start as I was expecting. It cost me some time to realize that the problem was this little typo in .github/worflow folder name!!! Awesome

To test if the problem was exactly this one I've created two tests:

This with the folder's wrong name This with the folder's correct name

As you can see validation started and work only in the second one

So, That's why I'm suggesting this documentation improvement here!

Please preserve this line to notify @roll (lead of this repository)

roll commented 3 years ago

Thanks @gabrielbdornas!

Sorry for the confusion those typos were small but unfortunately impactful.

Really happy to hear that Frictionless is helpful for your projects! cc @lwinfree The Github Action project is quite young so looking forward to hearing more feedback going forward =) Of course, please create issues if something doesn't work.